Andre, I left a comment on the pull request. But I will just copy them here as well.
I have a couple of comments and one suggestion. 1. What is the performance & GC implication with this change? I think most of the questions on this pull request is about the performance & GC implication. It would be good to show your benchmarking/testing methodology and the benchmark results to the community. 2. How are you going to handle topics with end-to-end encryption enabled? 3. How do you handle acknowledgment for the messages that have been filtered out and never sent to the consumers? I don't see it is discussed in the PIP. Especially, how is it related to different subscription types? One suggestion - If this PIP is approved, my recommendation is to use the NAR classloader to load the class. You can check how Pulsar uses NAR classloader for other interfaces. Thanks, Sijie On Mon, Nov 16, 2020 at 2:53 AM Kramer, Andre <andre.kra...@softwareag.com> wrote: > Sure, please feel free to copy the doc to wiki pages. It's mainly text so > can be converted easily. > > Cheers, > Andre > > -----Original Message----- > From: Sijie Guo <guosi...@gmail.com> > Sent: 13 November 2020 19:08 > To: Dev <dev@pulsar.apache.org> > Subject: Re: Proposal for Consumer Filtering in Pulsar brokers > > Andre, > > Is it possible to put it in a Google Doc (or similar collaboration tool) > that allows other people to make comments? Also, it would be easier for the > committers to copy the PIP to Pulsar wiki pages. > > Thanks, > Sijie > > On Fri, Nov 13, 2020 at 2:44 AM Kramer, Andre <andre.kra...@softwareag.com > > > wrote: > > > Hi Sijie, > > > > I had added a PIP style document to the pull request: > > https://github.com/andrekramer1/pulsar/blob/consumer-filter2-7-0/PIP-X > > X%20-%20Consumer-filtering.pdf Hopefully that could be used to start > > the discussion? > > > > Regards, > > Andre > > > > -----Original Message----- > > From: Sijie Guo <guosi...@gmail.com> > > Sent: 12 November 2020 18:32 > > To: Dev <dev@pulsar.apache.org> > > Subject: Re: Proposal for Consumer Filtering in Pulsar brokers > > > > Hi Andre, > > > > I didn't see the attached writeup. Can you write a PIP for this feature? > > Given it is a big feature, it would be good to discuss it through a PIP. > > > > - Sijie > > > > On Thu, Nov 12, 2020 at 6:17 AM Kramer, Andre > > <andre.kra...@softwareag.com > > > > > wrote: > > > > > Hello everyone, > > > > > > > > > > > > We at Software AG have prototyped adding filtering on Consumer > > > subscriptions in the Pulsar broker and are submitting our changes > > > for consideration under Apache 2.0 license. Please see pull request > > > [Consumer Filtering #8544 > > > https://github.com/apache/pulsar/pull/8544] > > > and attached write up. Comments welcome! > > > > > > > > > > > > Thanks, > > > > > > Andre > > > > > > > > > > > > andre.kra...@softwareag.com > > > This communication contains information which is confidential and > > > may also be privileged. It is for the exclusive use of the intended > > > recipient(s). If you are not the intended recipient(s), please note > > > that any distribution, copying, or use of this communication or the > > > information in it, is strictly prohibited. If you have received this > > > communication in error please notify us by e-mail and then delete > > > the > > e-mail and any copies of it. > > > Software AG (UK) Limited Registered in England & Wales 1310740 - > > > *http://www.softwareag.com/uk > > > * <http://www.softwareag.com/uk> > > > > > This communication contains information which is confidential and may > > also be privileged. It is for the exclusive use of the intended > > recipient(s). If you are not the intended recipient(s), please note > > that any distribution, copying, or use of this communication or the > > information in it, is strictly prohibited. If you have received this > > communication in error please notify us by e-mail and then delete the > e-mail and any copies of it. > > Software AG (UK) Limited Registered in England & Wales 1310740 - > > http://www.softwareag.com/uk > > > This communication contains information which is confidential and may also > be privileged. It is for the exclusive use of the intended recipient(s). If > you are not the intended recipient(s), please note that any distribution, > copying, or use of this communication or the information in it, is strictly > prohibited. If you have received this communication in error please notify > us by e-mail and then delete the e-mail and any copies of it. > Software AG (UK) Limited Registered in England & Wales 1310740 - > http://www.softwareag.com/uk >
