sijie commented on a change in pull request #80:
URL: https://github.com/apache/pulsar-helm-chart/pull/80#discussion_r521568693
##########
File path: charts/pulsar/templates/bookkeeper-configmap.yaml
##########
@@ -22,7 +22,7 @@ apiVersion: v1
kind: ConfigMap
metadata:
name: "{{ template "pulsar.fullname" . }}-{{ .Values.bookkeeper.component }}"
- namespace: {{ .Values.namespace }}
+ namespace: {{ .Values.namespace | default .Release.Namespace }}
Review comment:
Can you implement this using a template function?
Like what we did in
https://github.com/streamnative/charts/blob/master/charts/pulsar/templates/_helpers.tpl#L21
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
