jeantil commented on issue #66:
URL: 
https://github.com/apache/pulsar-helm-chart/issues/66#issuecomment-723224112


   I am confused, in your initial issue you provided the following reproduction 
steps:
   ```
   kubectl create ns pulsartest
   helm upgrade --install pulsar -n pulsartest apache/pulsar
   Error: namespaces "pulsar" not found
   ```
   the chart **does not** try to create/update/delete the namespace and the 
chart will succeed if you configure it correclty (pass `--set 
namespace=pulsartest`) still without creating/updating/deleting a namespace.So 
you are forced to repeat the namespace information which is suboptimal.
   
   The helm's best practice indicate that to avoid this repetition chart 
maintainers are not supposed to embbed namespace definitions in their 
templates. 
   The problem is that making the chart follow the official helm conventions ( 
which is easy)  will fail in some common helm/k8s workflows because of the 
rbac/FQDN issues i mention in the referenced comment.
   
   In the stream native chart they had already applied the other alternative I 
mentioned  : 
   > I am considering using defaulting instead of fully removing the namespace 
mentions
   > ```{{ .Values.namespace | default .Release.Namespace }}```
   
   They had left a default value in the values file which required you to pass 
`--set namespace=null` to get the desired behavior. The fix they applied to 
your issue was to remove the default value and align the documentation.
   
   I'm hoping one of the maintainers for the apache chart will comment on what 
they would consider the correct option for their chart :D


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to