Guangning, thanks for putting this together -1 (non binding) I am sorry but the source tarball contains a directory with name 'pulsar-manager-0.2.0-candidate-1' In my opinion this is not good, it should be pulsar-manager-0.2.0 or apache-pulsar-manager-0.2.0
Apart from this nit tests are passing (using JDK8 on Mac), signatures and checksums are good. I have also tested BKVM If you decide to create a new RC please take into account merging the upgrade of HerdDB https://github.com/apache/pulsar-manager/pull/330 Enrico Il giorno mar 8 set 2020 alle ore 16:53 Guangning E <eguangn...@gmail.com> ha scritto: > I'm very sorry. I seem to have added a wrong link. My key is here > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > Thanks, > Guangning > > Enrico Olivelli <eolive...@gmail.com> 于2020年9月8日周二 下午10:00写道： > > > Guagning, > > I can't find your key here > > https://dist.apache.org/repos/dist/release/pulsar/KEYS > > > > Enrico > > > > Il giorno mar 8 set 2020 alle ore 15:46 xiaolong ran < > > ranxiaolong...@gmail.com> ha scritto: > > > > > Thanks ganging, LGTM +1(non-binding) > > > > > > -- > > > Thanks > > > Xiaolong Ran > > > > > > > 在 2020年9月8日，下午6:13，Guangning E <guangn...@apache.org> 写道： > > > > > > > > Hi everyone, > > > > Please review and vote on the release candidate #1 for the version > > 0.2.0, > > > > as follows: > > > > [ ] +1, Approve the release > > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > The complete staging area is available for your review, which > includes: > > > > * Release notes [1] > > > > * The official Apache source and binary distributions to be deployed > to > > > > dist.apache.org [2] > > > > * Source code tag "release-0.2.0" [4] with git sha > > > > aec4262feb3ac1de565361df6d8e962f06d53a4f > > > > > > > > PulsarManager's KEYS file contains PGP keys we used to sign this > > release: > > > > https://dist.apache.org/repos/dist/release/pulsar/KEYS > > > > > > > > Please download these packages and review this release candidate: > > > > > > > > - Review release notes > > > > - Download the source package (verify shasum, and asc) and follow the > > > > instructions to build and run the pulsar-manager front end and back > end > > > > service. > > > > - Download the binary package (verify shasum, and asc) and follow the > > > > instructions to run run the pulsar-manager front end and back end > > > service. > > > > > > > > > > > > > > https://github.com/apache/pulsar-manager/wiki/Release-Candidate-Validation > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > majority > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > > > Source and binary files: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-manager/pulsar-manager-0.2.0-candidate-1/apache-pulsar-manager-0.2.0-bin.tar.gz > > > > > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-manager/pulsar-manager-0.2.0-candidate-1/apache-pulsar-manager-0.2.0-src.tar.gz > > > > > > > > SHA-512 checksums: > > > > > > > > > > > > > > 09e2b895274a0d0b906c92a26965958dca4656799b6f810b4813cdc0f56cdb9289d0c4a25aa644f8c3e3682fceb65bfb4d8fbe98d326c8ab2eabd89d9b4db685 > > > > apache-pulsar-manager-0.2.0-bin.tar.gz > > > > > > > > > > 998b63df04c2b6821bb9bcc6897c3b46bc2cf7c9a3f5ce084c5a92b10f48a20f76f8d616ee1e0f50ee065b359fa535f9f4d3612fab9bebe8da37a53592bddb60 > > > > apache-pulsar-manager-0.2.0-src.tar.gz > > > > > > > > >
