RobertIndie commented on a change in pull request #48:
URL: https://github.com/apache/pulsar-dotpulsar/pull/48#discussion_r472992463
##########
File path: src/DotPulsar/PulsarClient.cs
##########
@@ -80,7 +80,7 @@ public IProducer CreateProducer(ProducerOptions options)
producers[partID] =
CreateProducerWithoutCheckingPartition(subproducerOption);
}));
}
- Task.WaitAll(subproducerTasks.ToArray());
+
Task.WhenAll(subproducerTasks.ToArray()).ConfigureAwait(false).GetAwaiter().GetResult();
Review comment:
Yes, you're right. Async version of this function here is meaningless.
Fixed on 0a0207c.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
