Chickenzilla commented on pull request #23: URL: https://github.com/apache/pulsar-dotpulsar/pull/23#issuecomment-653311322
I was just coming back to this and went through all my outstanding merge conflicts when I discovered the lock executor was gone and object pooling was added! Less than a day ago apparently! Sorry I couldn't get to it sooner but kudos for moving forward with an implementation. I'm fine with closing this PR if you want now, but you may want to inspect the remaining diffs, I believe you may have a race condition waiting in your SequenceId that my code side-steps. To be honest I haven't had the chance to review the new code completely so apologies if I'm incorrect there. Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
