+1 (non-binding) Validate the binary distribution Validate Pub/Sub and Java Functions Validate Cassandra Connectors Validate Stateful Functions
Thanks, Guangning PengHui Li <codelipeng...@gmail.com> 于2020年6月16日周二 上午12:00写道： > Hi Chris, > > Thank you for following up on this! > > 1) The ‘apply-config-from-env.py’ was problematic for processing > environment variables. Because the behavior can vary whether the system > environments are substituted or not. Many different changes happened around > this script and we reached the consensus that we should avoid substituting > system environments. That means we will need to get this change into one of > releases. We will make sure the release note is updated to include this > change. > > 2) It is not a breaking change. The helm chart is a deployment script used > for deploying a (few) certain release(s). It usually evolves along with the > code changes. What we need to maintain is people can upgrade their k8s > clusters using a newer version of helm chart which is using a newer version > of Pulsar. That is one of the reasons that PMC maintains an official Helm > chart for its releases. > > Do they make sense to you? > > Regards, > Penghui > On Jun 15, 2020, 11:58 PM +0800, Jia Zhai <zhaiji...@gmail.com>, wrote: > > Regarding the helm issue, this seems not to be a break. It is hard to > make > > the new Pulsar version always work with every version of > pulsar-helm-chart. > > If the fix in Pulsar is right and needed, we should update the helm > chart. > > > > > > +1 based on my verification. > > > > OS: MacOS 10.15.5 > > > > - verified packages checksum and signatures ( asc and sha all good) > > - the source package rat check, licence check, build and unit test all > run > > successfully. > > - bin build from source, 'bin/pulsar standalone' and client > produce/consume > > runs well. > > - bin package, 'bin/pulsar standalone' and client produce/consume runs > well. > > > > > > Best Regards. > > > > > > Jia Zhai > > > > Beijing, China > > > > Mobile: +86 15810491983 > > > > > > > > > > On Mon, Jun 15, 2020 at 7:37 PM Chris Bartholomew > > <chris.bartholo...@kafkaesque.io.invalid> wrote: > > > > > Hi Penghui, > > > > > > I have already updated my Helm chart. That's not the issue here. This > is a > > > non-backward compatible change, meaning that folks running in > Kubernetes > > > using Helm charts and other manifests or those even those running with > > > their own deployment scripts in production may have to update them > before > > > upgrading to this software release. > > > > > > Considering that the project is being criticized as not being mature > enough > > > for "mission-critical" deployments, releasing a non-backward compatible > > > change doesn't seem like the right thing to do. It just gives the > critics > > > and the doubters fuel for their fire. > > > > > > Cheers, > > > Chris > > > > > > > > > > > > > > > > > > " > > > > > > On Sun, 14 Jun 2020 at 21:34, PengHui Li <codelipeng...@gmail.com> > wrote: > > > > > > > Hi, Chris > > > > > > > > Thanks for you feedback.I think you should update your helm chart. > Sijie > > > > has create a PR in apache/pulsar-helm-chart and update the helm > chart, > > > > maybe you can refer to > > > https://github.com/apache/pulsar-helm-chart/pull/20 > > > > . > > > > > > > > Regards, > > > > Penghui > > > > On Jun 11, 2020, 9:19 PM +0800, Chris Bartholomew > > > > <chris.bartholo...@kafkaesque.io.invalid>, wrote: > > > > > Hi PengHui, > > > > > > > > > > Thanks for putting together the candidate load. Unfortunately, I > have > > > > found > > > > > an issue. Because of changes to how environment variables are > applied, > > > > the > > > > > candidate load will not start when using the project Helm chart. I > have > > > > > documented my findings in > https://github.com/apache/pulsar/issues/7243 > > > . > > > > > This will create a bad experience for anyone trying to upgrade > their > > > > > deployment to 2.6.0. > > > > > > > > > > I suggest that https://github.com/apache/pulsar/pull/6579/files be > > > > removed > > > > > from the release until it can be fully tested with the Kubernetes > files > > > > and > > > > > Helm charts. > > > > > > > > > > Cheers, > > > > > Chris > > > > > > > > > > On Wed, 10 Jun 2020 at 07:35, PengHui Li <peng...@apache.org> > wrote: > > > > > > > > > > > This is the first release candidate for Apache Pulsar, version > 2.6.0. > > > > > > > > > > > > It fixes the following issues: > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/pulsar/pulls?q=milestone%3A2.6.0+-label%3Arelease%2F2.5.2+-label%3Arelease%2F2.5.1+ > > > > > > > > > > > > *** Please download, test and vote on this release. This vote > will > > > stay > > > > > > open > > > > > > for at least 72 hours *** > > > > > > > > > > > > Note that we are voting upon the source (tag), binaries are > provided > > > > for > > > > > > convenience. > > > > > > > > > > > > Source and binary files: > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.6.0-candidate-1/ > > > > > > > > > > > > SHA-512 checksums: > > > > > > > > > > > > > > > > > > > > 6c86a31ef6a9ffac2fb6830026d8d522e561a8cfbd5caed463ed78aa4de98829cf6e35ec7e7f65e99a8f3282d7cbf7a2bbc32a81d6d431e02f8bec445aed9552 > > > > > > apache-pulsar-2.6.0-bin.tar.gz > > > > > > > > > > > > > > > > > > > > > > > > > > b3b981776b6ebd9616243b8d4ee49add1d9b5031f74edc0e29fecee14cb2ca86e39dce58a98d23c8140a79eb2f1a9a093fc3c1c370d07d2491559a24272b8ac9 > > > > > > apache-pulsar-2.6.0-src.tar.gz > > > > > > > > > > > > Maven staging repo: > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachepulsar-1065/ > > > > > > > > > > > > The tag to be voted upon: > > > > > > v2.6.0-candidate-1(653ef409e5a3e72d7a7917d45b54c46e7bff5c16) > > > > > > https://github.com/apache/pulsar/releases/tag/v2.6.0-candidate-1 > > > > > > > > > > > > Release candidate validation: > > > > > > > https://github.com/apache/pulsar/wiki/Release-Candidate-Validation > > > > > > > > > > > > Pulsar's KEYS file containing PGP keys we use to sign the > release: > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > > > > > > > > > Please download the the source package, and follow the README to > > > build > > > > > > and run the Pulsar standalone service. > > > > > > > > > > > > > > > > > > > > > -- > > > > > Chris Bartholomew > > > > > Kafkaesque > > > > > chris.bartholo...@kafkaesque.io > > > > > > > > > > > > > -- > > > Chris Bartholomew > > > Kafkaesque > > > chris.bartholo...@kafkaesque.io > > > >
