blankensteiner commented on pull request #37:
URL: https://github.com/apache/pulsar-dotpulsar/pull/37#issuecomment-641140680


   Hi @mhelleborg 
   I haven't got a docker compose that will spin up a multi-broker and proxied 
cluster, but that would be cool though.
   However, I think I've found the problem with the PR.
   
   `return _serviceUrl.IsLoopback ? connection : await 
GetConnection(physicalUrl, cancellationToken).ConfigureAwait(false);`
   
   Here we are using 'physicalUrl' but should actually GetBrokerServiceUrl from 
the LookupTopicReponse.
   If you could fix that, test and rebase, then I can merge it and create a new 
release :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to