nickelozz opened a new pull request #18:
URL: https://github.com/apache/pulsar-helm-chart/pull/18


   ### Motivation
   
   The secret resources generation was appending a newline at the end of the 
JWT token strings (```\n```). From my understanding, this is not an issue 
inside Pulsar likely because it trims the contents of the JWT programmatically. 
However, when setting pulsar as a sink destination for 
[Vector](https://vector.dev/) (vector produces messages into Pulsar), I noticed 
the token was always invalid due to this extra newline.
   
   ### Modifications
   
   Remove newline from secret tokens generation by using the utility command 
tr. Granted, this is not the nicest way to go about it but given that the 
contents are JWT strings, it appears to do the job just fine while keeping 
everything else working (e.g.: producing/consuming as well as other components 
like Prometheus). Please advise if you have any concerns or suggestions.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to