2020-02-03 13:36:27 UTC - Konstantinos Papalias: @Konstantinos Papalias has joined the channel ---- 2020-02-03 22:36:40 UTC - Addison Higham: <https://github.com/apache/pulsar/pull/6199> ran into issue as we upgrade to 2.5.0 ---- 2020-02-03 22:37:56 UTC - Addison Higham: also, @Jerry Peng maybe I missed it, but I couldn't see it in the docs anywhere that technically there is a breaking change in a config value in that you now need to specifying the ```functionAuthProviderClassName```
---- 2020-02-03 22:41:43 UTC - Jerry Peng: Oh if there is I would say that is a bug ---- 2020-02-03 22:42:42 UTC - Jerry Peng: we should fix it. Are you talking about the KubernetesFunctionsAuthProvider that was the default auth provider when it was hard coded? ---- 2020-02-03 22:56:47 UTC - Addison Higham: yeah ---- 2020-02-03 23:29:11 UTC - Jerry Peng: @Addison Higham do you want to file a issue? Feel free to also work on a fix :smile: ---- 2020-02-03 23:29:22 UTC - Jerry Peng: we can release for 2.5.1 ---- 2020-02-03 23:29:43 UTC - Addison Higham: yeah, finishing up my upgrade and will file one tomorrow ---- 2020-02-03 23:29:53 UTC - Jerry Peng: :+1: ---- 2020-02-04 01:41:48 UTC - Sijie Guo: yes. there is a “breaking” change when the function runtime was refactored and that piece of code was not documented at well. ---- 2020-02-04 02:07:15 UTC - Moacy Barros: @Moacy Barros has joined the channel ---- 2020-02-04 02:09:17 UTC - Addison Higham: @Sijie Guo updated the commit here: <https://github.com/apache/pulsar/pull/6203> to fix the tests ---- 2020-02-04 02:09:22 UTC - Addison Higham: but yeah, I think that should work now ---- 2020-02-04 03:59:30 UTC - Eugen: > "deduplicate across producers" option I've created a PR for this sub-feature, <https://github.com/apache/pulsar/pull/6209> . I will add documentation for this after getting feedback from pulsar devs. Some tests like `CI - CPP, Python Tests / cpp-tests (pull_request)` and `CI - Integration - Function State / function-state (pull_request)` have failed - I think that pulsar CI is being reworked right now, so are these tests just failing (sometimes), or is this something I should look into? I would I have not created any backwards compatibility issues ---- 2020-02-04 04:08:36 UTC - Sijie Guo: > so are these tests just failing (sometimes), or is this something I should look into @tuteng and me are looking into those flaky tests. we are trying to improve the CI. if those CI jobs failed not related to your changes, feel free to ignore them for now. +1 : Eugen ----
