-1 (binding)
I'm seeing a couple of problems in starting the standalone in 2.5:
* The function workers tries to use "hostname" to connect to local
broker. If the hostname is not resolvable
the standalone will just fail to start. (we should instead use
"localhost" directly)
* The ZK upgrade is not working from zk-3.4.x from pulsar-2.4. While
the ZK-3.5.6 include the fix
for the missing snapshot, we need to add a flag to enable it (see:
ZOOKEEPER-3056).
Adding PRs for both fixes
Matteo
--
Matteo Merli
<mme...@apache.org>
On Fri, Dec 13, 2019 at 8:26 AM Enrico Olivelli <eolive...@gmail.com> wrote:
>
> +1 (non binding)
> Built from sources with JDK12
>
> Run unit/integration tests of a client application that launches an
> embedded Pulsar broker (inside the same process of the application),
> performs writes/reads using the Java client APIs (admin, producer and
> reader) and uses SubscriptionStats
>
> I noticed that:
> SubscriptionStats.msgBacklog is less accurate (sometimes tests fail
> reporting a value that is less than the expected value)
> PulsarService#getWebServiceAddress and PulsarService#getBrokerServiceUrl
> return a null value if called before calling PulsarService#start()
> in 2.4.2 they used to return the expected value even without starting the
> service
>
> Enrico
>
> Il giorno ven 13 dic 2019 alle ore 14:39 Guangning E <eguangn...@gmail.com>
> ha scritto:
>
> > +1 (non-binding)
> > https://github.com/apache/pulsar/wiki/Release-Candidate-Validation
> > Validate checksum
> > Validate the binary distribution
> > Validate Pub/Sub and Java Functions
> > Validate Connectors
> > Validate Stateful Functions
> > Validate RPM and DEB packages
> >
> > Thanks,
> > Guangning
> >
> > Yong Zhang <zhangyong1025...@gmail.com> 于2019年12月13日周五 下午4:57写道：
> >
> > > +1 (non-binding)
> > >
> > > - download the packages and verify the checksums
> > > - compile the source code successfully
> > > - produce and consume messages successfully
> > > - validate the functions and stateful functions
> > >
> > > Regards,
> > > Yong
> > >
> > > > On Dec 11, 2019, at 12:44 AM, Sijie Guo <si...@apache.org> wrote:
> > > >
> > > > This is the first release candidate for Apache Pulsar, version 2.5.0.
> > > >
> > > > It fixes the following issues:
> > > > https://github.com/apache/pulsar/milestone/22?closed=1
> > > >
> > > > *** Please download, test and vote on this release. This vote will stay
> > > open
> > > > for at least 72 hours ***
> > > >
> > > > Note that we are voting upon the source (tag), binaries are provided
> > for
> > > > convenience.
> > > >
> > > > Source and binary files:
> > > >
> > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.5.0-candidate-1/
> > > >
> > > > SHA-512 checksums:
> > > >
> > > >
> > >
> > b416abe38eb92abee0c003b68d3f0c813aaf9bba16c0fee596357edad2c66fe3d92f059fb9ff376f1361649c9faf48102c063033b07a2056aedfa25a1bb1a87b
> > > > apache-pulsar-2.5.0-bin.tar.gz
> > > >
> > >
> > c94f6bcba7945f20e309f0e1ec328a54839d399234600e8dd081d99b0aa47d6f7e5b0196c73ebbba2cf494d5df98091f0cd42b9e08077f34e4cb36c76e9bff53
> > > > apache-pulsar-2.5.0-src.tar.gz
> > > >
> > > > Maven staging repo:
> > > >
> > https://repository.apache.org/content/repositories/orgapachepulsar-1057/
> > > >
> > > > The tag to be voted upon:
> > > > v2.5.0-candidate-1 (98cca0accae7c0610e8a7b10a295e7ebde0cf1cf)
> > > > https://github.com/apache/pulsar/tree/v2.5.0-candidate-1
> > > >
> > > > Pulsar’s KEYS file containing PGP keys we use to sign the release:
> > > > https://dist.apache.org/repos/dist/release/pulsar/KEYS
> > > >
> > > > Please download the the source package, and follow the README to build
> > > > and run the Pulsar standalone service.
> > > >
> > > > Thanks,
> > > > Sijie
> > >
> > >
> >
