hrsakai commented on issue #56: Add listener support for consumer URL: https://github.com/apache/pulsar-client-node/pull/56#issuecomment-547745427 > I'll update the test dockerfile to install node 12 over the weekend. That should clear the CI issues. The docker image used in CI was upgraded 5 days ago, and the nodejs version was also upgraded from `v10.14.1` to` v10.17.0`. Since nodejs `v10.17.0` supports N-API v4, there is no need to update the test dockerfile. https://hub.docker.com/layers/apachepulsar/pulsar-build/ubuntu-16.04/images/sha256-d03f66e312923a5e84936d92cfa0af6c95977e5cd4ecd4edb42aa808d543eeab According to https://github.com/nodejs/node/pull/28643#discussion_r303047660, it seems that the thread-safe function is already stable in N-API v4, so there is no need to upgrade nodejs to v12. ``` The thread-safe function was marked as stable when N-API version 4 was released. At that time, all thread-safe function N-APIs were marked as stable, however, the overall heading (addressed in this PR) was forgotten. ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
