2019-09-16 14:39:46 UTC - Thomas Cothran: @Thomas Cothran has joined the channel ---- 2019-09-16 16:28:58 UTC - Rostom: @Rostom has joined the channel ---- 2019-09-16 17:08:56 UTC - Addison Higham: hrm... don't want to lose track of this commit: <https://github.com/apache/pulsar/pull/5043>, but still not sure why tests aren't passing... and also @Sijie Guo I am happy to help rip out the hacks, but I am not totally sure where they live or how involved that is? any pointers would be great ---- 2019-09-16 19:03:03 UTC - Shishir Pandey: @Shishir Pandey has joined the channel ---- 2019-09-16 23:23:49 UTC - Sijie Guo: @Addison Higham :
the change is here: <https://github.com/apache/pulsar/blob/master/pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/SerializeUtilsAspect.java> that is the original commit: <https://github.com/apache/pulsar/pull/2473> ---- 2019-09-16 23:25:12 UTC - Addison Higham: :thumbsup: , will take a crack at it ok_hand : Sijie Guo ---- 2019-09-17 05:23:03 UTC - Mark Andreev: @Mark Andreev has joined the channel ---- 2019-09-17 06:36:51 UTC - jia zhai: <https://github.com/apache/pulsar/pull/4963> @Sijie Guo @Penghui Li Would you please help review this again? Thanks. ---- 2019-09-17 06:43:40 UTC - Penghui Li: @jia zhai done! ---- 2019-09-17 06:43:46 UTC - jia zhai: Thanks ----
