2019-04-15 15:30:49 UTC - Karthik Ramasamy: @Jianfeng Qiao - c++ code is pretty high level. It should be fairly easy. ---- 2019-04-15 21:07:51 UTC - roman: @roman has joined the channel ---- 2019-04-15 21:09:53 UTC - roman: Hi, is schema registry still only for Java client? If so, is python implementation planned? ---- 2019-04-15 21:10:22 UTC - Matteo Merli: <https://pulsar.apache.org/docs/en/client-libraries-python/#schema> ---- 2019-04-16 00:27:07 UTC - Nick Rivera: @Nick Rivera has joined the channel ---- 2019-04-16 01:24:09 UTC - Nick Rivera: Hey all ---- 2019-04-16 01:25:03 UTC - Nick Rivera: I've been working on my fork to make pulsar-client-cpp compile on Windows, and I believe I have it ready ---- 2019-04-16 01:25:14 UTC - Nick Rivera: Is there a particular process for submitting a pull request? ---- 2019-04-16 01:25:46 UTC - Matteo Merli: :ok_hand::skin-tone-2: ---- 2019-04-16 01:26:09 UTC - Matteo Merli: No particular process, just open the PR :grinning: ---- 2019-04-16 01:26:13 UTC - Nick Rivera: Cool! ---- 2019-04-16 01:26:18 UTC - Nick Rivera: Somewhat related ---- 2019-04-16 01:26:29 UTC - Nick Rivera: In getting it to work on Windows, I discovered there's a deadlock ---- 2019-04-16 01:27:19 UTC - Matteo Merli: In which scenario? ---- 2019-04-16 01:27:21 UTC - Nick Rivera: it actually only deadlocks on Windows, because when using pthread, if a thread join would cause a deadlock it returns the error EDEADLK ---- 2019-04-16 01:27:29 UTC - Nick Rivera: when closing the Consumer ---- 2019-04-16 01:27:52 UTC - Nick Rivera: The Consumer sends a close request to the broker, who then responds with a success ---- 2019-04-16 01:28:39 UTC - Nick Rivera: that success response comes in on the worker thread owned by the ExecutorService, which then proceeds to attempt to close the ExecutorService ---- 2019-04-16 01:28:53 UTC - Nick Rivera: this results in the worker thread attempting to join itself ---- 2019-04-16 01:30:17 UTC - Nick Rivera: I can probably get you the full stack pretty quickly. I wrote a simple test app while getting everything to work on Windows ---- 2019-04-16 01:30:35 UTC - Matteo Merli: Nice catch! Can you open an issue for this to track. Also it would be good to fix it outside the windows pr, to make it easier to review just this fix ---- 2019-04-16 01:30:53 UTC - Nick Rivera: Totally! Unfortunately I don't have a fix for the deadlock yet :disappointed: ---- 2019-04-16 01:31:30 UTC - Matteo Merli: No problem, the description of it is good already ---- 2019-04-16 01:32:21 UTC - Nick Rivera: I'm not sure what the best way to combat it is atm. I figured I'd mention it so other Smart People can get on the case :slightly_smiling_face: ---- 2019-04-16 01:34:11 UTC - Nick Rivera: Alright, thanks for your input. I'll open the PR soon ---- 2019-04-16 01:43:03 UTC - Matteo Merli: :+1: ----
