On Wed, Oct 10, 2018 at 4:13 PM Matteo Merli <matteo.me...@gmail.com> wrote:
> On Wed, Oct 10, 2018 at 4:03 PM Sijie Guo <guosi...@gmail.com> wrote: > > > the proposal looks good to me. > > > > just out of curiosity, why PoolingPolicy only has `UnpooledHeap` and > > `PooledDirect`? > > > > I think these are the 2 that make sense (from my perspective): > > 1. Pooling heap memory still suffers from interactions with GC and will > still involve copying the buffers multiple times when reading/writing on > network. > Sure, it would reduce the allocation rate, but if one wants to pool > memory it's preferable to use direct memory. > > 2. Using unpooled direct memory for each buffer would be very slow so not > to be useful in practice > Make sense to me +1 then > > > -- > Matteo Merli > <mme...@apache.org> >
