I agree that we shouldn't need the entire CallContext in each & every task -- tasks should include whatever information is necessary to execute them, and in the end CallContext.copy() shouldn't be needed.
However, at least in Will's proposal, we would keep the existing framework around (with its unfortunate CallContext.copy()) in parallel with the new framework for some time. I don't see a big impetus to refactor this just yet. --EM On Wed, Aug 13, 2025 at 12:18 AM Robert Stupp <sn...@snazy.de> wrote: > Thanks for the reply Yufei, but the intent of all tasks-proposals is > to be able to execute tasks on _any_ node. Are you suggesting making > (Polaris)CallContext serializable? > > On Wed, Aug 13, 2025 at 3:12 AM Yufei Gu <flyrain...@gmail.com> wrote: > > > > > To still let TaskExecutorImpl making "safe clones", a functionality to > > get (fresh) instances of RealmContext is required. To enable this, the > > RealmContextResolver has been enhanced with "RealmContext lookups" by > > realm-ID. That in turn led to splitting the HTTP/REST-to-realm-context > > resolution into two parts: HTTP/REST-to-realm-ID and realm-ID-to-context. > > > > I'm not sure whether this refactor is beneficial. Avoiding the copying > of a > > CDI bean would require introducing a global RealmContext map to maintain > > the mapping between realmId and RealmContext instances. That feels > heavier > > and more complex than simply copying the context whenever needed. > > > > Yufei > > > > > > On Tue, Aug 12, 2025 at 6:18 AM Robert Stupp <sn...@snazy.de> wrote: > > > > > Hi all, > > > > > > quick heads up that there's a PR to remove CallContext.copy(), which > > > is only used from tasks. This change is also part of the effort to > > > have async & reliable tasks running "anywhere". > > > > > > Robert > > > > > > [1] https://github.com/apache/polaris/pull/2294 > > > >
