Perhaps I misunderstood the functionality of PR #1891 -- if so, I apologize. Per the vote in the mentioned thread, it seems that there is consensus to not run renovatebot on branches for released versions like 1.0.0, 1.2.3, and so on. I'm aligned with that.
If we maintained a branch like 1.x and planned to cut new releases from that (e.g. we have a 1.0 and we'll cut 1.1.0 from 1.x instead of from main) then I think that applying dependency upgrades to that 1.x could make sense. Additionally, upgrading dependencies for a released version like 1.2.3 may sometimes be necessary e.g. for security reasons. In these cases I am onboard to use renovate as a mechanism for either adhoc or automated dependency upgrades. In this case however, we have a branch release/1.0.x which looks like we would not cut new releases from. Rather, the branch itself represents the 1.0 release and accordingly I think renovatebot should not be automatically opening PRs against that branch. --EM On Tue, Jul 15, 2025 at 6:18 AM Robert Stupp <sn...@snazy.de> wrote: > Not sure what you mean Eric. > IIRC you merged the PR 1891, so I assumed you're also okay with that? > > On Tue, Jul 15, 2025 at 3:07 PM Eric Maynard <eric.w.mayn...@gmail.com> > wrote: > > > > Do we actually want it to run on release/1.0.x? Per "[DISCUSS] Disable > > renovatebot on release branches", it looks like we do not. > > > > On Tue, Jul 15, 2025 at 5:18 AM Robert Stupp <sn...@snazy.de> wrote: > > > > > Oh! > > > According to the dependency dashboard [1] it works on both main and > > > release/1.0.x :) > > > > > > [1] https://github.com/apache/polaris/issues/642 > > > > > > On Tue, Jul 15, 2025 at 2:16 PM Robert Stupp <sn...@snazy.de> wrote: > > > > > > > > Yea - it already created 5 PRs (the hourly limit). Let's see whether > > > > it catches the release/1.0.x branch as well. > > > > > > > > On Tue, Jul 15, 2025 at 2:12 PM Jean-Baptiste Onofré < > j...@nanthrax.net> > > > wrote: > > > > > > > > > > Good catch! > > > > > > > > > > I merged the PR and renovate works again. > > > > > > > > > > Thanks ! > > > > > > > > > > Regards > > > > > JB > > > > > > > > > > On Tue, Jul 15, 2025 at 2:03 PM Robert Stupp <sn...@snazy.de> > wrote: > > > > > > > > > > > > Hi all, > > > > > > > > > > > > I did some investigation on what's going on with Renovate, why > it's > > > no > > > > > > longer working. > > > > > > > > > > > > It seems to be broken by my PR [1] to let Renovate suggest patch > > > > > > version updates on 1.* release branches [1], which was done > knowing > > > > > > that Renovate supports multiple base branches in forking-Renovate > > > [2], > > > > > > but not knowing about another Renovate change [3] bringing back > the > > > > > > forking-renovate restriction for multiple base branches. > > > > > > > > > > > > The plan is to "eliminate the regex" [4], hoping that this is > enough > > > > > > to fix the issue (not much hope tho). If that doesn't work, fall > back > > > > > > to "main branch only" > > > > > > > > > > > > Will continue on this one. > > > > > > > > > > > > Robert > > > > > > > > > > > > > > > > > > > > > > > > [1] https://github.com/apache/polaris/pull/1891 > > > > > > [2] https://github.com/renovatebot/renovate/pull/36054 > > > > > > [3] https://github.com/renovatebot/renovate/pull/35579 > > > > > > [4] https://github.com/apache/polaris/pull/2052 > > > >
