Hi,
If I understand correctly, this effort is still in the "proposal state"
in Iceberg (the PR itself is still a draft). This means that nothing is
set "in stone" yet. Things can still change fundamentally, the proposal
can even be rejected.
IMHO we should wait adding code to Polaris until the change has been
merged and release, at least until the proposal got to a consensus and
the PR being merged. The risk of having an implementation that does not
match the upstream project's spec is real.
A parallel (and likely different) spec/implementation in Polaris would
be an option, but I'm not sure that would be a good thing, because users
could be confused and we in trouble having to potentially support
different approaches.
Also, consider how long for example the auth-manager or
oauth-token-deprecation changes took and the number of review rounds.
Thoughts?
Robert
On 09.06.25 23:51, Adnan Hemani wrote:
Hi Yufei,
Thanks for the comments, I’ve addressed all of them. The second half of the
document briefly outlines how we will transform the Polaris internal
persistence events into Iceberg Events to return back as part of the Iceberg
Event Endpoint.
Best,
Adnan Hemani
On Jun 8, 2025, at 4:02 PM, Yufei Gu <flyrain...@gmail.com> wrote:
Thanks Adnan for driving this. Left comments in the google doc.
The current schema proposal is good if this is only for Polaris internal
persistence. It'd also be a good idea to make sure it is
compatible with the Iceberg Event Endpoints [1][2].
[1]
https://www.google.com/url?q=https://docs.google.com/document/d/1WtIsNGVX75-_MsQIOJhXLAWg6IbplV4-DkLllQEiFT8/edit?pli%3D1%26tab%3Dt.0%23heading%3Dh.7bty2c61dvd7&source=gmail-imap&ust=1750028569000000&usg=AOvVaw10E0e7Djbd1WYMY8dGRnNO
[2]
https://www.google.com/url?q=https://github.com/apache/iceberg/pull/12584/files&source=gmail-imap&ust=1750028569000000&usg=AOvVaw0kMs3bVaBXRtZCTvStT3JI
Yufei
On Tue, Jun 3, 2025 at 10:19 PM Adnan Hemani
<adnan.hem...@snowflake.com.invalid> wrote:
Hi all,
Wanted to start this thread on getting community feedback for the schema
of a new `events` table, as described by my Iceberg Events API
implementation thread <
https://www.google.com/url?q=https://lists.apache.org/thread/nfp40hmwryybznxtgffvy4c5l5kk19ho&source=gmail-imap&ust=1750028569000000&usg=AOvVaw2zcBEWMfKLXrNZhXbETGB4>.
Schema can be found on this Google Doc - please feel free to comment
directly on the document and we can discuss in the comments section as
well:
https://www.google.com/url?q=https://docs.google.com/document/d/1AxaXy-DXE2g6rmFktA2foDI7k2zIjFzTKmI5mZnUjOs/edit?usp%3Dsharing&source=gmail-imap&ust=1750028569000000&usg=AOvVaw38W8LTWpVceP8bFhLVV_La
Best,
Adnan Hemani
--
Robert Stupp
@snazy
