It doesn't really matter. Robert, if I remove the flag, will you remove the -1 on the PR?
On Wed, May 7, 2025 at 10:43 AM Dmitri Bourlatchkov <di...@apache.org> wrote: > On Wed, May 7, 2025 at 11:29 AM Robert Stupp <sn...@snazy.de> wrote: > > > If federated principals cannot be created, it doesn't make sense to me > > to even have that flag. > > > > I think Robert has a point here. Still, from my POV (as I commented in GH > [1]) > exposing the same property in PrincipalRole and Principal at the same time > also > has merit, that is to keep API "symmetric" because those entities are > related > as far as Identity Federation is concerned, and we do expect potentially > importing > Principals later. > > I'm fine with both approaches (property in both entities now or property > just in role > now and in Principal when absolutely necessary). > > [1] > https://github.com/apache/polaris/pull/1353#pullrequestreview-2819283769 > > Cheers, > Dmitri. >
