I think it makes sense for us to also build some capabilities into the tools repo to build Polaris at a specific commit for testing purposes. If the Spark Catalog and Benchmarking code goes there they could both share this code for testing, ditto for the migration code.
On Fri, Mar 21, 2025 at 4:59 PM Yufei Gu <flyrain...@gmail.com> wrote: > I’m leaning toward placing it in a separate repository rather than in > https://github.com/apache/polaris. The benchmark tool is largely > self-contained and doesn’t have a strong dependency on the main codebase. > > IIUC, the only requirement is a running Polaris instance, which the tool > can connect to using the following configuration: > export CLIENT_ID=your_client_id > export CLIENT_SECRET=your_client_secret > export BASE_URL=http://your-polaris-instance:8181 > > Yufei > > > On Thu, Mar 20, 2025 at 6:05 AM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > > > Hi Ajantha, > > > > That's a good request. > > > > Imho, right now, before distributing any artifact (either on nightly > > build space https://nightlies.apache.org/), I prefer to have it "good > > enough" from a "legal" standpoint (e.g. LICENSE/NOTICE). > > > > I'm almost done about that for all artifacts (jar and distributions). > > I will open a PR soon. > > Once this PR is done, I will submit a way to provide nightly builds. > > > > Regards > > JB > > > > On Thu, Mar 20, 2025 at 10:27 AM Ajantha Bhat <ajanthab...@gmail.com> > > wrote: > > > > > > > I cannot think of any issue with storing that code in the > polaris-tools > > > repository. > > > > > > While contributing the `catalog migrator tool` to `polaris-tools`, I > > > encountered a challenge because this external repository needs to > depend > > on > > > Apache Polaris jars, which haven't been published yet by Apache > Polaris. > > If > > > we keep the tool in polaris-tools, we may need to wait for the nightly > > > build or official jar publication. > > > > > > - Ajantha > > > > > > On Thu, Mar 20, 2025 at 2:46 PM Pierre Laporte <pie...@pingtimeout.fr> > > > wrote: > > > > > > > On Wed, Mar 19, 2025 at 4:53 PM Jean-Baptiste Onofré < > j...@nanthrax.net> > > > > wrote: > > > > > > > > > Hi Pierre > > > > > > > > > > Thanks ! > > > > > > > > > > I have a general comment: do we want the benchmark tool as part of > > > > > Polaris "core" repo or on polaris-tools ? > > > > > As we can consider this as a benchmark "tool", maybe it makes sense > > to > > > > > host it in https://github.com/apache/polaris-tools. > > > > > > > > > > > > > > At this point, apart from the Gradle build files, the benchmark code > is > > > > completely contained under the benchmarks/ directory. And given it > > relies > > > > on the REST API, there is no real dependency to any specific Polaris > > > > version. > > > > > > > > I cannot think of any issue with storing that code in the > polaris-tools > > > > repository. > > > > > > > > -- > > > > > > > > Pierre > > > > > > >
