pjfanning opened a new pull request, #166:
URL: https://github.com/apache/poi-xmlbeans/pull/166

   Follow-up to #165, which made `xmlText2GenericDom` parse with 
`SAXHelper.newXMLReader(new XmlOptions())`. Callers had no way to change those 
defaults.
   
   This adds `xmlText2GenericDom(InputStream, Document, XmlOptions)`. The 
existing two-argument method delegates with `null`, so its behaviour is 
unchanged.
   
   The options it honours:
   - `setEntityExpansionLimit`
   - `setDisallowDocTypeDeclaration`
   - `setLoadDTDGrammar` / `setLoadExternalDTD`
   - `setEntityResolver`: if set, it replaces the ignoring resolver, so callers 
can opt in to resolving external entities. If not set, external entities are 
still ignored.
   
   The options are copied before use, and `null` means the defaults.
   
   New tests in `LoadSaveUtilsTest` cover null options, disallow-doctype, the 
expansion limit and a custom resolver. All 6 tests in the class pass locally.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to