jaragunde commented on PR #1561: URL: https://github.com/apache/poi/pull/1561#issuecomment-6847145489
I asked further and the answer is contradictory. Maybe we should keep an eye on future PRs: > what's the default in the project https://github.com/apache/poi/ ? GitHub will not create a blank commit. In the normal squash-and-merge flow, the squashed commit is created from the PR title, and the PR body becomes the commit description if there is one. So if you leave the squash message/description blank in the UI, the usual behavior is: - Commit title: the pull request title - Commit body/description: empty, if the PR body/description is blank - Result: one squashed commit on the target branch, not an empty commit For apache/poi specifically, the public repo doesn’t expose a custom merge-message override, so the default is effectively GitHub’s normal squash behavior: use the PR title as the squash commit title, **with no extra description unless you fill one in**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
