jaragunde opened a new pull request, #1534:
URL: https://github.com/apache/poi/pull/1534

   This is actually two bug fixes, the second fix surfaced when building a test 
for the first fix:
   
   * [Fix unconditional flipping of images in 
DrawShape.](https://github.com/apache/poi/commit/381f2c373b9ff85e242f014c2ea97120ec936789)
   
     When this code was refactored as part of 
[1539088d](https://github.com/apache/poi/commit/1539088d513d4bbafe6516a89db0df65d2885825),
 the condition that
   checked the value of the vertical/horizontal flip flag before applying
   the transformation was removed.
   
     This commit restores the conditional as originally stated, minus the
   cast that's not necessary now.
   
   * [Fix HSLFShape.setFlip(flip) methods when flip is 
false.](https://github.com/apache/poi/commit/8bb2df19fe743fba7c4e32048b251b8a845bd2fb)
   
     This method was unconditionally enabling the flip flag, regardless of
   the parameter value.
   
   * [Add test to exercise the flipping 
flags.](https://github.com/apache/poi/commit/b5822eb5ec5aa118100f5453f31d2701e7bf579e)
   
   Generated with Claude code with human review and testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to