pjfanning opened a new pull request, #1494: URL: https://github.com/apache/poi/pull/1494
Enables the test that #1493 added as `@Disabled`. Excel stops working out an improper fraction before its numerator exceeds an unsigned 32-bit int. POI stopped at the signed int limit instead. Results with `=TEXT(value, "?????????/?????????")`: | Value | Excel | Before | After | |---|---|---|---| | 2500.123456789 | `202510/81` | `202510/81` | `202510/81` | | 300000.707106781 | `2435705741/8119` | `1008902378/3363` | `2435705741/8119` | | 2100000000.12345 | `2100000000/1` | `2100000000/1` | `2100000000/1` | In each case Excel stops at the last convergent before the numerator would exceed 2^32 - 1. The next numerators are 27476334289, 5880013860 and 16800000001. For an improper fraction with a variable denominator, the fraction is now worked out for the part after the whole number. A package-private `SimpleFraction.buildFractionMaxDenominator` overload stops before `wholeNumber * denominator + numerator` exceeds 2^32 - 1. Fixed denominators and whole numbers of 2^31 or more go through the same paths as before. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
