pjfanning opened a new pull request, #1490: URL: https://github.com/apache/poi/pull/1490
Follow-up tidy up to #1486. - `XMLSlideShow.findPictureData` used `pic.getChecksum()`, which on an uncached picture reads the whole part (and parses its image header) via `cacheProperties()`, and then `pic.getData()` read the part again for the byte compare. The new package-private `XSLFPictureData.hasData(byte[], long)` computes the CRC from the bytes it reads and reuses them for the compare, so each candidate part is read at most once. - The checksum is now compared as a `long`, so there is no longer a byte-array conversion per candidate. - The collision test now also checks that real duplicates are still reused past a colliding entry, and that lookups on a reloaded deck (no cached checksums) find the right pictures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
