pjfanning opened a new pull request, #130: URL: https://github.com/apache/poi-xmlbeans/pull/130
Follow-up to #106 (XMLBEANS-658). `XmlValueComparison.content_equal` walks both trees until their content runs out. A value made by `copy()` is rooted at a document, so its walk ends on `ENDDOC`. An element inside a document ends on `END`. Because the two tokens differ, `x.copy().valueEquals(x)` returned false for every complex value. The fix treats either finish token as the end of the content. POI's `TestXWPFNumbering.testCompareAbstractNum` failed on 5.5.0-SNAPSHOT because of this: `XWPFNumbering.getIdOfAbstractNum` compares a copied `CTAbstractNum` against the numbering's own. - New `ValueEqualsTest.testCopyEqualsOriginal` fails without the fix and passes with it - Full `./gradlew test` passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
