jaragunde opened a new pull request, #969: URL: https://github.com/apache/poi/pull/969
Table styles contain rules for first and last rows/columns, even and odd rows/columns... When one of these rules is empty, we are supposed to fall back to the "whole table" rules. The fallback must also be applied for the format that's not explicitly specified in the specific rules. when the corresponding specific rule is missing some info. Fallback must also be applied when the corresponding specific rule is missing some info. A couple of examples from the reproducer/test file included: The included reproducer/test file contained a few problems related to table style application: * The second style for horizontal/vertical banding (band2H, band2V) was never applied. * In the table with horizontal banding enabled, the style band1H did not set a font color, POI returned a null font color instead of the color from wholeTable. * In the table with horizontal banding enabled, the style band2H did not set a background color, POI returned null instead of the color specified in wholeTable. This patches fixes the behaviors mentioned above, making POI behavior match the one from MS Office and LibreOffice. For extra context, this is a screenshot of one of the tables in the attached document, as displayed by PowerPoint: <img width="871" height="171" alt="image" src="https://github.com/user-attachments/assets/bcbfd244-4bf2-4048-8bb9-343d28eaf594"; /> This is the table rendered by POI on a Graphics2D context, before this patch: <img width="856" height="172" alt="image" src="https://github.com/user-attachments/assets/0dba1d18-f814-4347-9e13-3fb0b4934390"; /> And this is the render after this patch: <img width="850" height="171" alt="image" src="https://github.com/user-attachments/assets/c74621c3-1b1b-4596-8770-cf3be758b8b9"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
