pjfanning commented on code in PR #829:
URL: https://github.com/apache/poi/pull/829#discussion_r2192004938


##########
poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFParagraph.java:
##########
@@ -488,11 +488,11 @@ public String getFootnoteText() {
      * specified in the style hierarchy, then no alignment is applied to the
      * paragraph.
      *
-     * @return the paragraph alignment of this paragraph.
+     * @return the paragraph alignment of this paragraph. Can be null if not 
set.

Review Comment:
   I think your change for `setAlignment(null)` is actually ok. That change is 
more of a bug fix because `STJc.Enum en = STJc.Enum.forInt(align.getValue())` 
(existing code) will NPE if align=null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Reply via email to