ebourg commented on PR #462: URL: https://github.com/apache/poi/pull/462#issuecomment-2483246857
The pull request does contain proper test coverage, it expands the existing tests checking the header sector (`TestPOIFSStream.createWriteRead()`, `TestPOIFSStream.addBeforeWrite()` and `TestHeaderBlockReading.testConstructors()`) with extra assertions for the directory sector count field. I could add a MSI specific test but that would just duplicate the existing tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
