InfiniteLoop90 commented on PR #586: URL: https://github.com/apache/poi/pull/586#issuecomment-2080211381
Thanks for the feedback. I made the following changes: * Changed the `TestSXSSFWorkbookWithCustomZipEntrySource#validateTempFilesAreEncrypted` test so that it now passes. * Added a new test to assert that temp files are disposed of when closing the SXSSFWorkbook without needing to call `SXSSFWorkbook#dispose`. * Deprecated `SXSSFWorkbook#dispose`. Ready for re-review when ready. Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
