komarovd95 commented on PR #604:
URL: https://github.com/apache/poi/pull/604#issuecomment-1980796887

   > Can I ask you to test with Java 8. Neither this nor your previous PR 
compile with Java 8.
   > 
   > Issues like
   > 
   > ```
   > 
/Users/pj.fanning/svn/poi/poi-ooxml/src/test/java/org/apache/poi/xdgf/usermodel/section/geometry/TestPolylineTo.java:100:
 error: cannot infer type arguments for java.util.HashMap<K,V>
   >                 new HashMap<>() {{
   > ```
   > 
   > I will fix this locally so you don't need to fix it here - but if you 
submit more PRs, can you ensure that they compile?
   
   Sorry, my fault. I'll definitely check it next time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Reply via email to