That commit does not affect what I was talking about. The issue I was talking about is the * cost in compiling and generating the poi-ooxml-full code - code that does not change * the major cost in building poi-ooxml-lite - again code that rarely changes - but to build it you need to run all the poi-ooxml tests to work out which classes are needed * poi-integration which is a very slow set of tests that runs against every checked in file - including new files that were deliberately added because we need to write tests against broken files
A very high proportion of the PRs and patches that we get have no tests or broken tests or even don't compile and I think a lot of this is caused by * we don't use Git and GotHub so we can't run CI against the patches * the complexity of the build discourages from users from running the tests locally * running POI tests in IntelliJ can just work but occasionally, IntelliJ will decide to do a full build including poi-ooxml-full/poi-ooxml-lite rebuild On Thursday 22 February 2024 at 17:04:15 GMT+1, Axel Howind <a...@dua3.com> wrote: @PJ: Hi, I just ran a poi-ooxml build and then ran the tests using the profiler. I made a little code change (r1915953), and the profiler tells me it’s beneficial. I’m still a bit sceptic, can you verify the tests run faster now? Maybe that’s something I can improve on in the coming days. Cheers, Axel > Am 21.02.2024 um 20:27 schrieb PJ Fanning <fannin...@apache.org>: > ... > I, personally, have much more a problem with the build time wasted on > poi-ooxml-full, the complexity of poi-ooxml-lite and poi-integration - and > the fact that we can't automate our releases because of this complexity. I > have given up bringing up discussions about such items due to general lack of > engagement with the dev mailing list. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
