tballison commented on code in PR #477:
URL: https://github.com/apache/poi/pull/477#discussion_r1237326799
##########
poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java:
##########
@@ -297,11 +298,15 @@ public static String
getWorkbookDirEntryName(DirectoryNode directory) {
"It must be decrypted before use by XSSF, it cannot be
used by HSSF");
}
- // check for previous version of file format
- if (directory.hasEntry(OLD_WORKBOOK_DIR_ENTRY_NAME)) {
Review Comment:
Y, I don't like the backwards compatibility break that this proposed change
brings about. If we don't do this, though, then we'll have to change
`hasEntry(name)` and `getEntry(name)` to the case insensitive options
throughout our codebase. I can do that if desired.
Yep, I'll add that now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
