appbakers commented on pull request #312: URL: https://github.com/apache/poi/pull/312#issuecomment-1064845015
Okay. It seems deliberate. I found error while executing poi test after this change. so the close should not called inside SXSSFWorkbook.write() method. I am closing this request. > Task :poi-ooxml:test TestSXSSFWorkbook > bug53515() FAILED org.opentest4j.AssertionFailedError at TestSXSSFWorkbook.java:354 Caused by: java.io.IOException at TestSXSSFWorkbook.java:354 TestSXSSFBugs > bug60197_NamedRangesReferToCorrectSheetWhenSheetOrderIsChanged() FAILED java.lang.RuntimeException at SXSSFITestDataProvider.java:76 Caused by: java.io.IOException at POIXMLDocument.java:215 TestSXSSFBugs > testWriteDocumentTwice() FAILED java.io.IOException at POIXMLDocument.java:215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org