See
<https://ci-builds.apache.org/job/POI/job/POI-DSL-Windows-1.8/139/display/redirect?page=changes>
Changes:
[Marius Volkhart] Improve performance of HSLFPictureData#write
[Marius Volkhart] Deprecate functions that duplicate functionality
DrawingGroupRecord#processChildRecords and
AbstractEscherHolderRecord#convertRawBytesToEscherRecords duplicate the
functionality of AbstractEscherHolderRecord#decode. This makes the code harder
to follow, as it is not clear when certain access patterns repeat. Accordingly,
these functions are deprecated and flagged for removal.
[Marius Volkhart] Review EscherContainerRecord#getChildRecords() call sites for
unnecessary work
This started off as wanting to add the EscherContainerRecord#getChildCount()
function in order to do an efficient check for how many children the container
has. This was desirable in new code for editing HSSF pictures. The existing
option of calling getChildRecords().size() was undesirable as this requires a
list copy first.
In the process of finding call sites that would benefit from replacing
getChildRecords().size(), I realized that several other patterns would benefit
from eliminating a copy, such as iterating over the children in a for-each
loop, and indexed access to specific children.
[Marius Volkhart] Add the ability to edit HSLFPictureData contents
Pictures can now be edited by calling HSLFPictureData#setData(byte[]). The
byte[] should contain the image data as an image viewer might read it.
To enable this functionality, a tighter coupling between the EscherBSERecords
of the slideshow and the HSLFPictureData was required. This ensures that
changes in image data size are accurately recorded in the records.
In the course of coupling the records and the HSLFPictureData, various
scenarios arose where a mapping of records to pictures was non-trivial.
Accordingly, the HSLFSlideShowImpl#matchPicturesAndRecords(...) function was
added to perform a more sophisticated matching pass. This function is heavily
exercised by org.apache.poi.hslf.usermodel.TestBugs.testFile[5] and
PPTX2PNG.render[2], as well as the new
TestPictures#testSlideshowWithIncorrectOffsets().
Closes #225
[Marius Volkhart] Make picture loading in HWPF PicturesTable easier to
understand
The recursion is no longer necessary due to the more defined structure of
OfficeArtContent.
[Marius Volkhart] Add documentation to PICFAndOfficeArtData
Adjust call sites based on defined behavior.
[PJ Fanning] change gradle build to get unreleased xmlbeans jar from ci-builds
(like ant build does)
[Marius Volkhart] Simplify OfficeArtContent#getBStoreContainer method
Due to the new structure of the class, we can be more specific about how we
load the BStore.
[PJ Fanning] change gradle build to get unreleased xmlbeans jar from ci-builds
(like ant build does)
[Marius Volkhart] Rename EscherRecordHolder to OfficeArtContent
While the class does indeed hold EscherRecords, due to recent refactoring it is
much more structured now than it was before. The contents of the class now
closely resemble the OfficeArtContent structure referenced in the MS-DOC spec.
Naming the class after the specification structure makes it easier to find and
understand.
[Marius Volkhart] Rework EscherRecordHolder parsing
Modify the parsing done by EscherRecordHolder to be more deterministic. The
format of the OfficeArtContent structure, which the EscherRecordHolder
represents, is well defined in the MS-DOC spec. A clear class structure makes
it easier to reason about the availability of data.
[Marius Volkhart] Add documentation to EscherRecordTypes#DG_CONTAINER
[Marius Volkhart] Simplify initialization of HWPF EscherRecordHolder
[Marius Volkhart] Add documentation for HWPF FileInformationBlock DggInfo
methods
This documentation comes from [MS-DOC] - v20191119.
------------------------------------------
[...truncated 188.80 KB...]
[junitlauncher] Tests run: 18, Failures: 0, Aborted: 0, Skipped: 1, Time
elapsed: 0.070000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.TestXSSFSimpleShape
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.013000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.TestXSSFTable
[junitlauncher] Tests run: 29, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.335000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.TestXSSFTableColumn
[junitlauncher] Tests run: 3, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.030000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.TestXSSFTextParagraph
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.012000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.TestXSSFTextRun
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.007000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.TestXSSFUnicodeSurrogates
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.025000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.TestXSSFVMLDrawing
[junitlauncher] Tests run: 5, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.134000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.TestXSSFWorkbook
[junitlauncher] Tests run: 62, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 1.138000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.charts.TestXDDFChartLegend
[junitlauncher] Tests run: 3, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.010000 sec
[junitlauncher]
[junitlauncher] Running
org.apache.poi.xssf.usermodel.charts.TestXDDFManualLayout
[junitlauncher] Tests run: 2, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.006000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.charts.TestXSSF3DChartData
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.026000 sec
[junitlauncher]
[junitlauncher] Running
org.apache.poi.xssf.usermodel.charts.TestXSSFCategoryAxis
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.005000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.charts.TestXSSFChartAxis
[junitlauncher] Tests run: 8, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.068000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.charts.TestXSSFChartTitle
[junitlauncher] Tests run: 6, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.091000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.charts.TestXSSFDateAxis
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.012000 sec
[junitlauncher]
[junitlauncher] Running
org.apache.poi.xssf.usermodel.charts.TestXSSFLineChartData
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.006000 sec
[junitlauncher]
[junitlauncher] Running
org.apache.poi.xssf.usermodel.charts.TestXSSFScatterChartData
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.008000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.charts.TestXSSFValueAxis
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.004000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.extensions.TestXSSFBorder
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.001000 sec
[junitlauncher]
[junitlauncher] Running
org.apache.poi.xssf.usermodel.extensions.TestXSSFCellFill
[junitlauncher] Tests run: 6, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.040000 sec
[junitlauncher]
[junitlauncher] Running
org.apache.poi.xssf.usermodel.extensions.TestXSSFHeaderFooter
[junitlauncher] Tests run: 10, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.026000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.usermodel.helpers.TestColumnHelper
[junitlauncher] Tests run: 16, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.025000 sec
[junitlauncher]
[junitlauncher] Running
org.apache.poi.xssf.usermodel.helpers.TestHeaderFooterHelper
[junitlauncher] Tests run: 2, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.001000 sec
[junitlauncher]
[junitlauncher] Running
org.apache.poi.xssf.usermodel.helpers.TestXSSFColumnShifting
[junitlauncher] Tests run: 2, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.004000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.util.TestCTColComparator
[junitlauncher] Tests run: 2, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.001000 sec
[junitlauncher]
[junitlauncher] Running
org.apache.poi.xssf.util.TestEvilUnclosedBRFixingInputStream
[junitlauncher] Tests run: 3, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.001000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xssf.util.TestNumericRanges
[junitlauncher] Tests run: 2, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.000000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.TestAllExtendedProperties
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.035000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.TestDocumentProtection
[junitlauncher] Tests run: 10, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.469000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.TestNecessaryOOXMLClasses
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.010000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.TestPackageCorePropertiesGetKeywords
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.015000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.TestXWPFBugs
[junitlauncher] Tests run: 4, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.314000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.extractor.TestExternalEntities
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.019000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.extractor.TestXWPFWordExtractor
[junitlauncher] Tests run: 24, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 1.225000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.model.TestXWPFDecorators
[junitlauncher] Tests run: 2, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.048000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.model.TestXWPFHeaderFooterPolicy
[junitlauncher] Tests run: 3, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.222000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestChangeTracking
[junitlauncher] Tests run: 3, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.041000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestColumn
[junitlauncher] Tests run: 4, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.069000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFAbstractNum
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.001000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFBugs
[junitlauncher] Tests run: 11, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.227000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFChart
[junitlauncher] Tests run: 4, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.051000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFComment
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.015000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFDocument
[junitlauncher] Tests run: 21, Failures: 0, Aborted: 0, Skipped: 1, Time
elapsed: 0.368000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFEndnote
[junitlauncher] Tests run: 4, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.019000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFEndnotes
[junitlauncher] Tests run: 2, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.007000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFFootnote
[junitlauncher] Tests run: 4, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.018000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFFootnotes
[junitlauncher] Tests run: 3, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.023000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFHeader
[junitlauncher] Tests run: 6, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.157000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFHeadings
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.064000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFNumbering
[junitlauncher] Tests run: 8, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.110000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFParagraph
[junitlauncher] Tests run: 29, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.276000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFPictureData
[junitlauncher] Tests run: 5, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.146000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFRun
[junitlauncher] Tests run: 34, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.219000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFSDT
[junitlauncher] Tests run: 7, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.150000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFSmartTag
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.016000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFStyles
[junitlauncher] Tests run: 10, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.141000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFTable
[junitlauncher] Tests run: 17, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.082000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFTableCell
[junitlauncher] Tests run: 11, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.073000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.xwpf.usermodel.TestXWPFTableRow
[junitlauncher] Tests run: 8, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.041000 sec
-test-ooxml-write-testfile:
compile-ooxml-lite:
[echo] Create ooxml-lite schemas
[copy] Copying 1 file to
<https://ci-builds.apache.org/job/POI/job/POI-DSL-Windows-1.8/ws/build>
[copy] Copying 1 file to
<https://ci-builds.apache.org/job/POI/job/POI-DSL-Windows-1.8/ws/build>
[copy] Copying 1 file to
<https://ci-builds.apache.org/job/POI/job/POI-DSL-Windows-1.8/ws/build>
[mkdir] Created dir:
<https://ci-builds.apache.org/job/POI/job/POI-DSL-Windows-1.8/ws/build\dist\maven\poi-ooxml-lite>
[jar] Building jar:
<https://ci-builds.apache.org/job/POI/job/POI-DSL-Windows-1.8/ws/build\dist\maven\poi-ooxml-lite\poi-ooxml-lite-5.0.1-SNAPSHOT.jar>
-test-excelant-check:
test-excelant:
[junitlauncher]
[junitlauncher] Running org.apache.poi.ss.excelant.TestBuildFile
[junitlauncher] Tests run: 14, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 3.368000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.ss.excelant.TestExcelAntPrecision
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.005000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.ss.excelant.TestExcelAntSet
[junitlauncher] Tests run: 2, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.020000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.ss.excelant.TestExcelAntSetDoubleCell
[junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.002000 sec
[junitlauncher]
[junitlauncher] Running
org.apache.poi.ss.excelant.TestExcelAntUserDefinedFunction
[junitlauncher] Tests run: 2, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.002000 sec
[junitlauncher]
[junitlauncher] Running
org.apache.poi.ss.excelant.util.TestExcelAntEvaluationResult
[junitlauncher] Tests run: 4, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.004000 sec
[junitlauncher]
[junitlauncher] Running org.apache.poi.ss.excelant.util.TestExcelAntWorkbookUtil
[junitlauncher] Tests run: 23, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 1.566000 sec
[junitlauncher]
[junitlauncher] Running
org.apache.poi.ss.excelant.util.TestExcelAntWorkbookUtilFactory
[junitlauncher] Tests run: 2, Failures: 0, Aborted: 0, Skipped: 0, Time
elapsed: 0.002000 sec
-test-excelant-write-testfile:
test:
compile-integration:
[javac] Compiling 28 source files to
<https://ci-builds.apache.org/job/POI/job/POI-DSL-Windows-1.8/ws/build\integration-test-classes>
[javac] Support for javac --release has been added in Java9 ignoring it
[mkdir] Created dir:
<https://ci-builds.apache.org/job/POI/job/POI-DSL-Windows-1.8/ws/build\integration-test-classes\META-INF\versions\9>
[jar] Building jar:
<https://ci-builds.apache.org/job/POI/job/POI-DSL-Windows-1.8/ws/build\dist\maven\poi-integration\poi-integration-5.0.1-SNAPSHOT.jar>
-test-integration-check:
test-integration:
[junitlauncher]
[junitlauncher] Running org.apache.poi.stress.TestAllFiles
[junitlauncher] Failed: #1633 spreadsheet\54764.xlsx XSSF
[junitlauncher] Failed: #2411 spreadsheet\poc-xmlbomb-empty.xlsx XSSF
[junitlauncher] Failed: #2413 spreadsheet\poc-xmlbomb.xlsx XSSF
[junitlauncher] Failed: #2432 spreadsheet\sample-beta.xlsx XSSF
[junitlauncher] Tests run: 7689, Failures: 4, Aborted: 0, Skipped: 0, Time
elapsed: 193.512000 sec
BUILD FAILED
<https://ci-builds.apache.org/job/POI/job/POI-DSL-Windows-1.8/ws/build.xml>:1792:
The following error occurred while executing this line:
<https://ci-builds.apache.org/job/POI/job/POI-DSL-Windows-1.8/ws/build.xml>:1342:
Some test(s) have failure(s)
Total time: 21 minutes 39 seconds
Build step 'Invoke Ant' marked build as failure
[SpotBugs] Skipping execution of recorder since overall result is 'FAILURE'
Archiving artifacts
[Fast Archiver] Compressed 5.58 MB of artifacts by 12.3% relative to #135
Skipping publisher since build result is FAILURE
Recording test results
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
