I see. From a user perspective bouncycastle & co will still be optional but it will be us who catch ClassNotFoundException.
It's fine then to make them mandatory. On Thu, Nov 5, 2020 at 12:37 AM Andreas Beeker <[email protected]> wrote: > I haven't tested it, but I assume we can catch the ClassNotFoundException. > So when defined as "requires static" the POI module would load and throw a > ClassNotFound/NotDefined when the code is reached. > When we define it as "requires" and the dependencies aren't on the module > path, I think it will crash in the beginning. > > Andi > > > On 04.11.20 21:11, Yegor Kozlov wrote: > > Does it mean that the JPMS modules will not load if these new > dependencies > > are missing? > > > > Won't it be an acceptance killer? > > > > > > Yegor > > > > > > ср, 4 нояб. 2020 г., 22:40 Andreas Beeker <[email protected]>: > > > >> Hi, > >> > >> we have a number of optional dependencies (bouncycastle, xmlsec, batik > and > >> now pdfbox and others) which can be easily not/included on the > classpath. > >> > >> On the modulepath, one need to use the --add-modules argument to > activate > >> those modules even when they were declared as "requires static" in the > >> module-info. > >> > >> I would like to make the optional dependencies mandatory. > >> > >> Pro: > >> + users don't need to fiddle around with the maven dependencies and > don't > >> need to add add-modules arguments. > >> > >> Neutral: > >> * drive space is not really an issue nowadays > >> > >> Con: > >> - there might be side effects with existing dependencies > >> > >> What is your opinion? > >> > >> > >> Andi > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
