Hi, I think its OK to commit it now and release the next major version for POI / XmlBeans when we are ready with trunk. When one of our remaining non-jigsaw dependencies switches we have to adapt, but I don't think we need to push that.
What bugs me a bit is the way our modules (main, scratchpad, ooxml) are tailored - but we've already discussed this: https://bz.apache.org/bugzilla/show_bug.cgi?id=62355 http://apache-poi.1045710.n5.nabble.com/Single-Java-9-module-jar-td5730294.html http://apache-poi.1045710.n5.nabble.com/Apache-POI-and-Maven-modules-mavenization-td5713558.html#a5713579 http://apache-poi.1045710.n5.nabble.com/Review-62355-td5730687.html#a5730762 Opposed to what I've said/planned in #62355, I think now, we should move to multi release module and keeping the module tailoring in POI 5.0.0. For POI 6.0.0 we might think of a different module layout. WRT the dependencies, I would prefer to have strong dependencies opposed to static ones - and maybe a less amount for each module. Instead of forcing the user to provide the whole lot, I rather would like to split certain features in its own modules, e.g. document signing and SVG rendering. WRT the build, as our build is still JDK 8 based, I need to provide module-info.class files in our source. Maybe we can rebase the build to JDK 9+ and use the "--release 8" option in javac instead ... Maybe we could change our jenkins strategy to * release on the latest stable JDK * build / test on JDK 8 * integration test on JDK 8 with the binaries of the latest stable This would have the benefit, that providing JDK release/version specific fixes wouldn't be a hassle. I'll push my changes now in - as most of the code isn't affected (... yet). Andi
signature.asc
Description: OpenPGP digital signature
