Hi Dominik, >From what I can see within the xdgf package there are two tests. I also observed that mocks are not used within the project. I was unable to get vsdump program in order to check the structure of the sample file "test_text_extraction.vsdx". How can get it ? I have been able to run the tests and they both passed but I am unable to find one of the text that was used in the assertion. I also want to ask about the scope of what has been done in order not to write test aimlessly. I think it would be better to write test for the usecases that has been considered for development till date.
Regards, Lukman. On Fri, Jan 26, 2018 at 1:06 PM, Murphy, Mark <murphym...@metalexmfg.com> wrote: > Could the functionality be written to use H2 if it exists in the > classpath, but stick with the current process if it does not? > > -----Original Message----- > From: Dominik Stadler [mailto:dominik.stad...@gmx.at] > Sent: Friday, January 26, 2018 5:10 AM > To: POI Developers List <dev@poi.apache.org> > Subject: Re: adding dependencies on h2 and mockito > > Hi, > > Mockito for testing is fine for me, H2 as requirement for everybody sounds > a bit heavy, would we still keep it optional unless somebody actually uses > this functionality? I.e. if you have Maven/Gradle dependencies it wouldn't > be dragged in by default? > > Thanks... Dominik. > > On Fri, Jan 26, 2018 at 9:03 AM, pj.fanning <fannin...@yahoo.com> wrote: > > > Are there any objections to me adding dependencies on h2 jar > > dependency for > > https://github.com/apache/poi/pull/85 and a test dependency on mockito? > > I think mockito would be useful for allowing us to test edge cases. > > An example is https://svn.apache.org/viewvc? > > view=revision&revision=1822253 > > where creating an XSLFTextRun with a null Font Size is not > straightforward. > > With mockito, it is very easy to produce such an instance. > > > > > > > > -- > > Sent from: > > http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional > > commands, e-mail: dev-h...@poi.apache.org > > > > >
