Hi, thanks for the detailed writeup, the functionality looks like it would be useful in many cases where memory is limited and files are large, we encounter these on a regular basis on the mailing lists and stackoverflow.
A few questions upfront: * How would you ensure feature-parity compared to HSSF/XSSF implementation? There are a large number of things that are possible in a workbook, do you plan to support all those or only a subset? * The text seems to indicate that there is already some code already available. Can we take a look? You can start a fork of Apache POI from https://github.com/apache/poi/ easily and do the changes there so others can take a look and suggest improvements/changes. Or is it a standalone piece of code? * How would you ensure that the code is maintained over time? As this sounds like quite a large chunk of code, are you planning to continue to invest some time in the long run? We had some cases where code was "donated", but never looked at afterwards, which is bad as it increases the code-base, but also increases number of bug-reports and areas that are not well covered by tests. Thanks... Dominik. On Sun, Dec 25, 2016 at 11:49 AM, Renjith R <[email protected]> wrote: > I don't know if you are able to see the screenshot in my previous mail. > Following was your comment. > I would start working on it if you think it worths adding. > > *From: *Dominik Stadler <[email protected]> > *Subject: *Re: Suggestion on how to read huge excel files. > *Date: *2015-06-20 15:24 (+0530) > *List: *[email protected] > <https://lists.apache.org/[email protected]> > > It seems not that many people need similar functionality currently, > however it looks useful for handling very large documents. > > I looked at it and it looks good, some comments: > > * The finalize() in the Beans looks strange and should not be needed, > these members are freed anyway and having to implement finalize() > always looks fishy! > > Thanks... Dominik. > > > > On Sun, Dec 25, 2016 at 4:12 PM, Renjith R <[email protected]> > wrote: > >> Ok. I recall that. It was you who did the code review that time. >> >> >> >> >> On Sun, Dec 25, 2016 at 4:04 PM, Renjith R <[email protected]> >> wrote: >> >>> Thanks, Dominik. I'll try to resend it. >>> Let me know if you can see the attachments. >>> >>> On Fri, Dec 23, 2016 at 6:57 AM, Renjith R <[email protected]> >>> wrote: >>> >>>> Hi Developers, >>>> >>>> Couple of years back I suggested an enhancement to read very large >>>> excel files using StAX api. Attached the document. Unfortunately, I did not >>>> get a chance to work on it. Do you think it will make sense if I start >>>> working on it?. Kindly let me know your suggestions. >>>> >>>> regards, >>>> Renjith >>>> >>> >>> >> >
