https://bz.apache.org/bugzilla/show_bug.cgi?id=58787
--- Comment #40 from Javen O'Neal <[email protected]> --- Two other changes: # Rather than saving all property template values as Shorts, I stored higher-level objects (BorderStyle and BorderExtent) when available. This user code, makes unit tests, and error messages easier to read while also allowing us to deprecate and remove meaningless code/id fields on enums. > public Object getTemplateProperty(CellAddress cell, String property) from [1] # As a marginal performance improvement, I used 4 Map.containsKey calls rather than for-looping over all the keys in cell style template to count getNumBorders and getNumBorderColors [2]. [1] https://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/util/BorderPropertyTemplate.java?revision=1748075&view=markup&pathrev=1748292#l928 [2] https://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/util/BorderPropertyTemplate.java?revision=1748075&view=markup&pathrev=1748292#l888 -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
