https://bz.apache.org/bugzilla/show_bug.cgi?id=58787
--- Comment #30 from Mark Murphy <[email protected]> --- (In reply to Javen O'Neal from comment #26) > (In reply to Javen O'Neal from comment #22) > > 1. DrawingBorders example: Use CellRangeAddress("B2:D5") to make it easier > > to see what's going on > Applied in r1747888 > > > 3. Try to find more descriptive names for PropertyTemplate and Extent. > Applied in r1747884. Using BorderPropertyTemplate and BorderExtent. > > > 7. Create a blocker to this bug: a re-write/deprecation of short borderTypes > > in favor of enums. > Applied in r1747868. I converted borderTypes from short to BorderStyles enum. > The colors will remain as short values, since they are indices into the > color table (indexed+custom). Sorry for taking so long to send my patches to you. If I had added my changes, you wouldn't have had to do so much work. Instead of BorderPropertyTemplate I was using CellStyleTemplate as it would be useful for other CellStyle attributes beside Border attributes. For example I had planned to add fills to it as well. I moved away from BorderPropertyTemplate since that name seems limiting to me. If I had sent my patch sooner, you would have known that. My fault, but just to prevent too many from using BorderPropertyTemplate, we may want to change that sooner rather than later. Thanks for taking your time to work on this. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
