https://bz.apache.org/bugzilla/show_bug.cgi?id=58365

Hannes Erven <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33098|0                           |1
        is obsolete|                            |

--- Comment #3 from Hannes Erven <[email protected]> ---
Created attachment 33143
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33143&action=edit
Suggested patch, version 2

Javen, thank you for your suggestions.

I'll attach a new patch that includes a new class
org.apache.poi.ss.util.CellAddress and now suggests a Sheet.getCellComments()
with return type Map<CellAdress, Comment> method.

Internally, XSSF's CommentsTable still uses String cell references (addresses,
in fact) to manage the comments; on first sight, changing that is possible, but
will bloat the patch.

Also, I noticed that various XSSF implementation use CellReference(row,col) as
a CellAddress replacement. I guess that's the places you meant that would also
benefit from a switch to CellAddress ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to