https://issues.apache.org/bugzilla/show_bug.cgi?id=56911
Bug ID: 56911 Summary: PlfLfo.add(LFO, LFOData) results in IOOBE Product: POI Version: 3.11-dev Hardware: All OS: All Status: NEW Severity: normal Priority: P2 Component: HWPF Assignee: dev@poi.apache.org Reporter: ya...@kundas.net The following code in the method will always result in a IOOBE: _rgLfo[_lfoMac + 1] = lfo; _rgLfoData[_lfoMac + 1] = lfoData; should be: _rgLfo[_lfoMac] = lfo; _rgLfoData[_lfoMac] = lfoData; Sadly, this code is only reachable from the external org.apache.poi.hwpf.HWPFDocument#registerList(HWPFList) method, and has no tests. Furthermore, org.apache.poi.hwpf.model.TestListTables has a single test which does nothing - it uses a fixture that causes the first "if" to essentially skip the test. I am not familiar with this object model, so I cannot provide a sensible test. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org