https://issues.apache.org/bugzilla/show_bug.cgi?id=56814
Uwe Schindler (ASF) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31894|0 |1 is obsolete| | --- Comment #10 from Uwe Schindler (ASF) <[email protected]> --- Created attachment 31895 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31895&action=edit New patch Hi, I reviewed the patch and made some changes: - In StreamHelper, I set OutputKeys in the identity transformer, to prettyprint (as done by dom4j) and also ste standalone attribute (as required by openxml). - In StreamHelper I prevented the transformer from closing the outputstream (using a CloseShieldOutputStream like in TIKA, unfortunately it was not available to POI). The problem: some transformers close the outputstream (from StreamResult), which would break ZIPOutputStream. - I removed stax.Namespace from the properties parser, useless there, as namespace prefixes are not used while parsing - I moved the methods to add xmlns attributes from POI to openxml, because this would have added a wrong relationship. It is now in DocumentHelper - I fixed a incorrect namespaceprefix in the coreProperties. openxml document should use "cp" prefix. - I removed the thread safety test again, because I made the methods that use the factories synchronized. This has no overhead in Java 6, if not used from many threads. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
