[ 
https://issues.apache.org/jira/browse/PIG-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277222#comment-16277222
 ] 

Rohini Palaniswamy commented on PIG-5315:
-----------------------------------------

1) FileLocalizer.fetchFile will be repeated twice which will be wasteful if the 
file is being fetched from hdfs/s3. Can you create a overloaded loadScript 
method that takes FetchFile as well?
2) beginNestedScript can be changed to beginNestedScript(File) and the setters 
can be called in that method instead of doing it in loadScript.
3) Initializing serializedScript and truncatedScript to "" is redundant.

> pig.script is not set for scripts run via PigServer
> ---------------------------------------------------
>
>                 Key: PIG-5315
>                 URL: https://issues.apache.org/jira/browse/PIG-5315
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Rohini Palaniswamy
>            Assignee: Satish Subhashrao Saley
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.18.0
>
>         Attachments: PIG-5315-1.patch, PIG-5315-2.patch
>
>
> ScriptState.get().setScript() is only called in Main and BoundScript and not 
> in PigServer.registerScript



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to