[ https://issues.apache.org/jira/browse/PIG-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162648#comment-16162648 ]
Nandor Kollar edited comment on PIG-5298 at 9/12/17 8:16 AM: ------------------------------------------------------------- [~rohini] it seems that Jetty is used only in Piggybank, and like you said, it is used just for its EL implementation. I'm not familiar with the history of Jetty, but it seems that they had their own EL implementation (or at least they had an artifact which included an EL implementation), and at one point they [decided to use|https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-jsp/pom.xml#L92] Glassfish's EL implementation. Depending on such an old Jetty version is not the best I think, it is already [deprecated|https://en.wikipedia.org/wiki/Jetty_(web_server)#History]. Since it seems Pig only needs an EL implementation, I thought we can use Tomcat's EL instead of pulling the entire Jetty server. What do you think? Should we still pull Jetty (or maybe just Jetty JSP module would be enough), use Tomcat's EL, or use Glassfish's EL, like Jetty does? was (Author: nkollar): [~rohini] it seems that Jetty is used only in Piggybank, and like you said, it is used just for its EL implementation. I'm not familiar with the history of Jetty, but it seems that they had their own EL implementation (or at least they had an artifact which included an EL implementation), and at one point they [decided to use|https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-jsp/pom.xml] Glassfish's EL implementation. Depending on such an old Jetty version is not the best I think, it is already [deprecated|https://en.wikipedia.org/wiki/Jetty_(web_server)#History]. Since it seems Pig only needs an EL implementation, I thought we can use Tomcat's EL instead of pulling the entire Jetty server. What do you think? Should we still pull Jetty (or maybe just Jetty JSP module would be enough), use Tomcat's EL, or use Glassfish's EL, like Jetty does? > Verify if org.mortbay.jetty is removable > ---------------------------------------- > > Key: PIG-5298 > URL: https://issues.apache.org/jira/browse/PIG-5298 > Project: Pig > Issue Type: Improvement > Affects Versions: 0.17.0 > Reporter: Adam Szita > Assignee: Nandor Kollar > Attachments: PIG-5298_1.patch > > > Although we pull in jetty libraries in ivy Pig does not depend on > org.mortbay.jetty explicitly. The only exception I see is in Piggybank where > I think this can be swapped by javax.el-api and log4j. > We should investigate (check build, run unit tests across all exec modes) and > remove if it turns out to be unnecessary. -- This message was sent by Atlassian JIRA (v6.4.14#64029)