[ https://issues.apache.org/jira/browse/PIG-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087361#comment-16087361 ]
BELUGA BEHR commented on PIG-5268: ---------------------------------- [~rohini] [~nkollar] I understand that these trivial changes can be burdensome for the gain, but attracting more developers can sometimes hinge on how beat-up the code is. Additionally someone who is evaluating the code base to build a product on, they may be turned off by dead code, bad formatting, and bad code re-use. I know I would question it. I would question how much care was put into a product. So, I don't think there's anything wrong with putting some polish and shine on a project used by many production systems. My goal would be to, over time, mold the project into a better direction that people open up and are excited by. These are marked appropriately as trivial. Spare cycles can be dedicated to some cleanup. I have a customer interested in using Pig, so I was just starting to get a feel for the project by submitting a couple of trivial patches. I don't know how helpful I'll be on full feature requests, but I can review the open tickets. Thanks for considering this patch. > Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage > ---------------------------------------------------------------- > > Key: PIG-5268 > URL: https://issues.apache.org/jira/browse/PIG-5268 > Project: Pig > Issue Type: Improvement > Components: data > Affects Versions: 0.17.0 > Reporter: BELUGA BEHR > Priority: Trivial > Attachments: PIG-5268.1.patch, PIG-5268.2.patch > > > # Optimize for case where {{asCollection}} is empty > # Tidy up -- This message was sent by Atlassian JIRA (v6.4.14#64029)