[ 
https://issues.apache.org/jira/browse/PIG-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009837#comment-16009837
 ] 

Rohini Palaniswamy commented on PIG-5135:
-----------------------------------------

This patch is good to go. Just two minor comments.
   1) isFiledSplits -> isFileSplits
   2) Some cleanup unrelated to this patch but would be good to do as it 
touches that code - Get rid of the static activeSplit variable and 
getActiveSplit method in PigInputFormat. Do not seem to be used anywhere and it 
is not a good idea to have a static state.  Also remove PigInputFormat.sJob 
which has been deprecated for long.

> HDFS bytes read stats are always 0 in Spark mode
> ------------------------------------------------
>
>                 Key: PIG-5135
>                 URL: https://issues.apache.org/jira/browse/PIG-5135
>             Project: Pig
>          Issue Type: Bug
>          Components: spark
>            Reporter: liyunzhang_intel
>            Assignee: Adam Szita
>             Fix For: spark-branch
>
>         Attachments: PIG-5135.0.patch, PIG-5135.1.patch
>
>
> I discovered this while running TestOrcStoragePushdown unit test in Spark 
> mode where the test depends on the value of this stat.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to