> On July 28, 2014, 11:12 p.m., Daniel Dai wrote: > > Looks good. I will also try to make the register part of the loader/storer, > > so we don't need to register so many jars. After that, I will change the > > tests afterward.
Way better. Why din't I think of that before ??. Was planning to do that for AvroStorage like we do in HBaseStorage as json-simple-1.1.jar is not part of hadoop 2.x lib anymore. That would make it easier for users as well. We should put the code to addDependencyJars in Util class so that all Load/StoreFunc can make use of it. - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24013/#review48928 ----------------------------------------------------------- On July 28, 2014, 9:55 p.m., Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24013/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 9:55 p.m.) > > > Review request for pig. > > > Bugs: PIG-4077 > https://issues.apache.org/jira/browse/PIG-4077 > > > Repository: pig > > > Description > ------- > > See PIG-4077 > > > Diffs > ----- > > trunk/src/org/apache/pig/builtin/OrcStorage.java 1613871 > trunk/src/org/apache/pig/impl/util/orc/OrcUtils.java 1613871 > trunk/test/e2e/pig/build.xml 1613871 > trunk/test/e2e/pig/conf/default.conf 1613871 > trunk/test/e2e/pig/conf/local.conf 1613871 > trunk/test/e2e/pig/drivers/TestDriverPig.pm 1613871 > trunk/test/e2e/pig/tests/orc.conf PRE-CREATION > trunk/test/org/apache/pig/builtin/TestOrcStorage.java 1613871 > > Diff: https://reviews.apache.org/r/24013/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Dai > >
