[
https://issues.apache.org/jira/browse/PDFBOX-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950263#comment-17950263
]
Tilman Hausherr commented on PDFBOX-6000:
-----------------------------------------
On line 239, wouldn't it be faster to check {{name.length()}} instead of
{{name.startsWith("uni")}}?
> remove unnecessary iteration and StringBuilder creation
> -------------------------------------------------------
>
> Key: PDFBOX-6000
> URL: https://issues.apache.org/jira/browse/PDFBOX-6000
> Project: PDFBox
> Issue Type: Improvement
> Components: Parsing
> Affects Versions: 2.0.34, 3.0.5 PDFBox, 4.0.0
> Reporter: Axel Howind
> Assignee: Andreas Lehmkühler
> Priority: Minor
> Fix For: 2.0.35, 3.0.6 PDFBox, 4.0.0
>
> Attachments:
> remove_unnecessary_iteration_and_StringBuilder_creation.patch
>
>
> As the size is known beforehand, we can see that the loop runs exactly once.
> So the loop can be removed and we can avoid storing the input in a temporary
> StringBuilder instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
